netdev - Re: [PATCH] net: Swap ver and type in pppoe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 01 Jul 2013 18:20:19 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	xiaosuo@...il.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] net: Swap ver and type in pppoe_hdr

From: Changli Gao <xiaosuo@...il.com>
Date: Sat, 29 Jun 2013 00:15:51 +0800

> Ver and type in pppoe_hdr should be swapped as defined by RFC2516
> section-4.

I can't believe this has been wrong for more than 8 years.

But, of course, it is possible.  Especially since we never check these
'ver' and 'type' fields on packet input, and we always set them both
to the same value ('1') on output.

Applied, thanks.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html