netdev - Re: [PATCH V2 1/9] net/mlx5: Mellanox Connect-IB, core driver part 1/3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 04 Jul 2013 07:17:41 -0700
From:	Joe Perches <joe@...ches.com>
To:	Jack Morgenstein <jackm@....mellanox.co.il>
Cc:	Or Gerlitz <ogerlitz@...lanox.com>, roland@...nel.org,
	linux-rdma@...r.kernel.org, netdev@...r.kernel.org,
	davem@...emloft.net, eli@....mellanox.co.il, moshel@...lanox.com,
	Eli Cohen <eli@...lanox.com>
Subject: Re: [PATCH V2 1/9] net/mlx5: Mellanox Connect-IB, core driver part
 1/3

On Thu, 2013-07-04 at 16:26 +0300, Jack Morgenstein wrote:
> On Wednesday 03 July 2013 23:29, Joe Perches wrote:
> > On Wed, 2013-07-03 at 20:13 +0300, Or Gerlitz wrote:
> > > From: Eli Cohen <eli@...lanox.com>
> > 
> > trivial comments:
> > 
> > > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/cmd.c b/drivers/net/ethernet/mellanox/mlx5/core/cmd.c
> > []
> > > +static const char *deliv_status_to_str(u8 status)
> > > +{
> > > +	switch (status) {
> > > +	case MLX5_CMD_DELIVERY_STAT_OK:
> > > +		return "no errors";
> > []
> > > +	default:
> > > +		return "unknown status code\n";
> > > +	}
> > > +}
> > Likely unnecessary newline for default case
> All the cases here have newlines between them, to enhance readability.
> (not just the default). If you feel strongly about this, I'll do the change
> for V3.

Not the vertical spacing, the newline inside the quotes.
ie: "unknown status code\n" should be "unknown status code"


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html