| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Thu, 4 Jul 2013 19:03:52 +0200 (CEST) From: Enrico Mioso <mrkiko.rs@...il.com> To: Bjørn Mork <bjorn@...k.no> cc: Enrico Mioso <mrkiko.rs@...il.com>, Ben Hutchings <bhutchings@...arflare.com>, netdev@...r.kernel.org Subject: Re: [PATCH V3 2/2 RESEND] Introduce huawei_cdc_ncm driver thank you !! you're right. Enthusiasm took me! :) I'll re-read SubmittingPatches and prepare some scripts (if they do not already exist). :) On Thu, 4 Jul 2013, Bj?rn Mork wrote: ==Date: Thu, 04 Jul 2013 15:19:46 +0200 ==From: Bj?rn Mork <bjorn@...k.no> ==To: Enrico Mioso <mrkiko.rs@...il.com> ==Cc: Ben Hutchings <bhutchings@...arflare.com>, netdev@...r.kernel.org ==Subject: Re: [PATCH V3 2/2 RESEND] Introduce huawei_cdc_ncm driver == ==Enrico Mioso <mrkiko.rs@...il.com> writes: == ==> This new driver, handles devices that mimic the NCM standard, but using NCM as ==> a transport layer to encapsulate other protocols (i.e. AT protocol). ==> ==> Signed-off-by: Enrico Mioso <mrkiko.rs@...il.com> ==> --- ==> V3: ==> - fixed typo in Kconfig (help text) ==> ==> diff --git a/drivers/net/usb/Kconfig b/drivers/net/usb/Kconfig ==> index 287cc62..33cb175 100644 ==> --- a/drivers/net/usb/Kconfig ==> +++ b/drivers/net/usb/Kconfig ==> @@ -246,6 +246,18 @@ config USB_NET_CDC_NCM ==> * ST-Ericsson M343 HSPA Mobile Broadband Modem (reference design) ==> * Ericsson F5521gw Mobile Broadband Module ==> ==> +config USB_NET_HUAWEI_CDC_NCM ==> + tristate "Huawei-style CDC NCM support" ==> + depends on USB_USBNET ==> + select USB_WDM ==> + select USB_NET_CDC_NCM ==> + help ==> + This driver aims to support huawei-style NCM devices, that use ncm as a ==> + transport for other protocols. ==> + To compile this driver as a module, choose M here: the module will be ==> + called huawei_cdc_ncm. ==> + ==> config USB_NET_CDC_MBIM ==> tristate "CDC MBIM support" ==> depends on USB_USBNET == ==Sorry, but editing a patch directly is too risky. You shouldn't do ==that. This does not apply anymore because there now is a line missing ==here... == ==This is nitpicking, but it needs to be correct for the patches to be ==accepted. == ==Before resubmitting, I suggest: == == - check all the patches with scripts/checkpatch.pl == - fix absolutely all ERRORs. You may ignore some WARNINGs if there are == good reasons to do so (e.g the 80 character limit) == - mail all patches to yourself, and save as you receive them == - apply the received patches to a clean net-next based branch using == "git am <patch>" == - verify the result (build it after each patch is applied and play with == related config options to make sure nothing breaks) == ==Also please note that net-next is currently closed due to the merge ==window being open: http://www.spinics.net/lists/netdev/msg242161.html == ==I don't know exactly what the policy wrt new drivers is, but you can ==assume that David is pretty busy with the stuff he already has queued. ==So it is better to hold this work until after v3.11-rc1 is out and David ==announces that he has opened net-next again. == ==And I also believe you should include your final patch to cdc_ncm.c as ==part 3/3 of this series. Otherwise the ordering and dependencies are ==not clear. That patch can be applied on it's own, but it won't make any ==sense to do so. Better make that clear. == == == ==Bj?rn == -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists