netdev - Re: [PATCH] include: net: Add parameter desc to fix waring when generating docs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 5 Jul 2013 01:43:10 +0300
From:	Luciano Coelho <coelho@...com>
To:	Sam Bristow <sam.bristow@...il.com>
CC:	Johannes Berg <johannes@...solutions.net>,
	"David S. Miller" <davem@...emloft.net>,
	<linux-wireless@...r.kernel.org>, <netdev@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] include: net: Add parameter desc to fix waring when
 generating docs

On Fri, 2013-07-05 at 09:59 +1200, Sam Bristow wrote:
> 'make htmldocs' was generating a warning about a missing parameter description
> for gfp.
> 
> Earlier patch was missing my signed-off-by line...
> Signed-off-by: Sam Bristow <sam.bristow@...il.com>
> ---

You have a typo in the patch subject (it was not there in your previous
version ;).

Also, you shouldn't add explanations about the different versions of the
patch in the commit message (in you case the "Earlier patch was missing
my signed-off-by line..." text).  If you want to add this kind of
comments, add it after the "---" under the Signed-of tags.

One more thing, it's a good idea to use [PATCH v2] when you're sending a
second version of the same patch.  That can be easily done with git
format-patch (and also with git send-email) by using an argument like
this: --subject-prefix="PATCH v2"

--
Luca.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html