lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 10 Jul 2013 13:40:35 +0200 From: Hannes Frederic Sowa <hannes@...essinduktion.org> To: Nicolas Dichtel <nicolas.dichtel@...nd.com>, netdev@...r.kernel.org, yoshfuji@...ux-ipv6.org, petrus.lt@...il.com, davem@...emloft.net Subject: Re: [PATCH RFC] ipv6: fix route selection if kernel is not compiled with CONFIG_IPV6_ROUTER_PREF On Wed, Jul 10, 2013 at 01:15:04PM +0200, Hannes Frederic Sowa wrote: > On Wed, Jul 10, 2013 at 09:54:58AM +0200, Nicolas Dichtel wrote: > > Le 09/07/2013 23:57, Hannes Frederic Sowa a écrit : > > >Are we sure we decrement all sibling's rt6i_nsiblings? Shouldn't we > > >start iterating from fn->leaf? But this does not seem to cause it, > > >because my trace does not report any calls to fib6_del_route. > > Note sure to follow you, but all siblings are listed in rt6i_siblings, so > > it must be enough. > > My hunch was to iterate over fn->leaf->rt_next and compare the metrics like we > do when adding a new route. Then take that rt6_info->rt6i_siblings list_head > to iterate over the remaining siblings. But I did not review that part > carefully, need to check later. Just checked, it is fine. I was distracted by the way the initial rt6_sibling list was constructed. Thanks, Hannes -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists