netdev - RE: [net-next 03/15] ixgbe: fix fc autoneg ethtool reporting.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 30 Jul 2013 16:17:57 +0000
From:	"Skidmore, Donald C" <donald.c.skidmore@...el.com>
To:	David Miller <davem@...emloft.net>,
	"Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"gospo@...hat.com" <gospo@...hat.com>,
	"sassmann@...hat.com" <sassmann@...hat.com>
Subject: RE: [net-next 03/15] ixgbe: fix fc autoneg ethtool reporting.

> -----Original Message-----
> From: David Miller [mailto:davem@...emloft.net]
> Sent: Monday, July 29, 2013 10:19 PM
> To: Kirsher, Jeffrey T
> Cc: Skidmore, Donald C; netdev@...r.kernel.org; gospo@...hat.com;
> sassmann@...hat.com
> Subject: Re: [net-next 03/15] ixgbe: fix fc autoneg ethtool reporting.
> 
> From: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
> Date: Mon, 29 Jul 2013 05:51:59 -0700
> > @@ -67,15 +67,39 @@ static s32 ixgbe_disable_pcie_master(struct
> ixgbe_hw *hw);
> >   **/
> >  s32 ixgbe_device_supports_autoneg_fc(struct ixgbe_hw *hw)  {
> > +	bool supported = false;
>  ...
> > +	return supported;
> 
> If the function is returning bool, fix the function's return type from 's32' to
> 'bool'.
> 
> 
> > -		    (ixgbe_device_supports_autoneg_fc(hw) == 0)) {
> > +		    (ixgbe_device_supports_autoneg_fc(hw))) {
> 
> I think the outermost parenthesis in
> "(ixgbe_device_supports_autoneg_fc(hw))"
> should be removed.

Thanks Dave, I'll clean this up and send the new patches to Jeff.

-Don Skidmore <donald.c.skidmore>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html