netdev - RE: [PATCH net-next 1/6] qlcnic: Add ethtool statistics for board temperature.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 31 Jul 2013 18:09:00 +0000
From:	Himanshu Madhani <himanshu.madhani@...gic.com>
To:	David Miller <davem@...emloft.net>
CC:	netdev <netdev@...r.kernel.org>,
	Dept-NX Linux NIC Driver 
	<Dept_NX_Linux_NIC_Driver@...gic.com>
Subject: RE: [PATCH net-next 1/6] qlcnic: Add ethtool statistics for board
 temperature.

> -----Original Message-----
> From: David Miller [mailto:davem@...emloft.net]
> Sent: Tuesday, July 30, 2013 7:27 PM
> To: Himanshu Madhani
> Cc: netdev; Dept-NX Linux NIC Driver
> Subject: Re: [PATCH net-next 1/6] qlcnic: Add ethtool statistics for board
> temperature.
> 
> From: Himanshu Madhani <himanshu.madhani@...gic.com>
> Date: Tue, 30 Jul 2013 21:54:19 -0400
> 
> > From: Himanshu Madhani <himanshu.madhani@...gic.com>
> >
> > o Added ethtool statistics to display adapter board
> >   temperature.
> >
> > Signed-off-by: Himanshu Madhani <himanshu.madhani@...gic.com>
> 
> A statistic is a count of events, this is not such a thing.
> 
> Furthermore, even if this fit the model of statistical events, there is no way
> for the user to know what units the value is in.
> 
> Sorry I'm not applying these patches.

I am dropping this patch from this series and will implement HWMON API for sensing temperature.

I am resubmitting rest of the patches in this series which are unrelated to the above patch.

Thanks, 
-Himanshu
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html