lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 30 Jul 2013 20:35:02 -0700 From: Joe Perches <joe@...ches.com> To: Eric Dumazet <eric.dumazet@...il.com> Cc: Cong Wang <amwang@...hat.com>, netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Yuchung Cheng <ycheng@...gle.com>, Neal Cardwell <ncardwell@...gle.com> Subject: Re: [Patch net-next] tcp_metrics: rearrange fields to avoid holes On Tue, 2013-07-30 at 20:24 -0700, Eric Dumazet wrote: > On Wed, 2013-07-31 at 11:13 +0800, Cong Wang wrote: > > On Tue, 2013-07-30 at 20:08 -0700, Eric Dumazet wrote: > > > Oh well, this patch is pure noise... > > Mind to be specific? > > > > I know saving 8 bytes is not interesting for you, but it is for me, > > since I need some room in struct tcp_metrics_block for union inet_addr. > > With this patch, I don't have to make struct tcp_metrics_block expand to > > 3 cachelines. :) > > Do you see how this explanation is rather different than the one you > gave in the changelog ? Eric, do you see how your own original reply was unwarranted? > And it would be more logical to put the "unsigned long last_syn_loss" at > the beginning of the structure, instead after an array of 17 bytes. True, using "unsigned long" instead of "long unsigned int" would likely be better too. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists