netdev - Re: [PATCH net-next v5 6/7] vxlan: Add tx-vlan offload support.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 1 Aug 2013 10:24:39 -0700
From:	Pravin Shelar <pshelar@...ira.com>
To:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
Cc:	netdev@...r.kernel.org, stephen@...workplumber.org
Subject: Re: [PATCH net-next v5 6/7] vxlan: Add tx-vlan offload support.

On Thu, Aug 1, 2013 at 6:11 AM, Sergei Shtylyov
<sergei.shtylyov@...entembedded.com> wrote:
> Hello.
>
>
> On 01-08-2013 3:14, Pravin B Shelar wrote:
>
>> Following patch allows transmit side vlan offload for vxlan
>> devices.
>
>
>> Signed-off-by: Pravin B Shelar <pshelar@...ira.com>
>> ---
>> v2-v3:
>>   - Set NETIF_F_HW_VLAN_STAG_TX feature.
>>   - Added WARN on vlan tag push.
>>   - Fixed hw_features.
>> ---
>>   drivers/net/vxlan.c |   18 +++++++++++++++++-
>>   1 files changed, 17 insertions(+), 1 deletions(-)
>
>
>> diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c
>> index f9c7c75..2f35a2b 100644
>> --- a/drivers/net/vxlan.c
>> +++ b/drivers/net/vxlan.c
>
> [...]
>
>> @@ -1123,13 +1124,25 @@ int vxlan_xmit_skb(struct net *net, struct
>> vxlan_sock *vs,
>
> [...]
>
>> +       if (vlan_tx_tag_present(skb)) {
>> +               if (unlikely(!__vlan_put_tag(skb,
>> +                                            skb->vlan_proto,
>> +                                            vlan_tx_tag_get(skb)))) {
>> +                       WARN_ON(1);
>> +                       return -ENOMEM;
>> +               }
>
>
>                 if (WARN_ON(!__vlan_put_tag(skb,
>                                             skb->vlan_proto,
>                                             vlan_tx_tag_get(skb))))
>                         return -ENOMEM;
>
> should be equivalent.

ok. I will update the patch.

>
> WBR, Sergei
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html