netdev - Re: [Patch net-next 1/2] net: fix a compile error when CONFIG_NET_LL_RX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 01 Aug 2013 00:18:03 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	amwang@...hat.com
Cc:	netdev@...r.kernel.org, eliezer.tamir@...ux.intel.com
Subject: Re: [Patch net-next 1/2] net: fix a compile error when
 CONFIG_NET_LL_RX_POLL is not set

From: Cong Wang <amwang@...hat.com>
Date: Thu,  1 Aug 2013 11:10:24 +0800

> From: Cong Wang <amwang@...hat.com>
> 
> When CONFIG_NET_LL_RX_POLL is not set, I got:
> 
> net/socket.c: In function ‘sock_poll’:
> net/socket.c:1165:4: error: implicit declaration of function ‘sk_busy_loop’ [-Werror=implicit-function-declaration]
> 
> Fix this by adding a nop when !CONFIG_NET_LL_RX_POLL.
> 
> Cc: Eliezer Tamir <eliezer.tamir@...ux.intel.com>
> Cc: David S. Miller <davem@...emloft.net>
> Signed-off-by: Cong Wang <amwang@...hat.com>

Is this really a net-next specific problem?  Doesn't it happen in
'net' too?

If so, it should be fixed in 'net', not just 'net-next'.