netdev - Re: bridge: disable snooping if there is no querier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 06 Aug 2013 08:47:22 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Dave Jones <davej@...hat.com>
Cc:	netdev@...r.kernel.org,
	Linus Lüssing <linus.luessing@....de>,
	"David S. Miller" <davem@...emloft.net>
Subject: Re: bridge: disable snooping if there is no querier

On Tue, 2013-08-06 at 11:18 -0400, Dave Jones wrote:
> On Sun, Aug 04, 2013 at 12:52:27AM +0000, Linux Kernel wrote:
>  > Gitweb:     http://git.kernel.org/linus/;a=commit;h=b00589af3b04736376f24625ab0b394642e89e29
>  > Commit:     b00589af3b04736376f24625ab0b394642e89e29
>  > Parent:     cf3c4c03060b688cbc389ebc5065ebcce5653e96
>  > Author:     Linus Lüssing <linus.luessing@....de>
>  > AuthorDate: Thu Aug 1 01:06:20 2013 +0200
>  > Committer:  David S. Miller <davem@...emloft.net>
>  > CommitDate: Wed Jul 31 17:40:21 2013 -0700
>  > 
>  >     bridge: disable snooping if there is no querier
>  >     
>  >     Signed-off-by: Linus Lüssing <linus.luessing@....de>
>  >     Signed-off-by: David S. Miller <davem@...emloft.net>
>  
>  > diff --git a/net/bridge/br_multicast.c b/net/bridge/br_multicast.c
>  > @@ -1198,6 +1206,9 @@ static int br_ip6_multicast_query(struct net_bridge *br,
>  >  		max_delay = mld2q->mld2q_mrc ? MLDV2_MRC(ntohs(mld2q->mld2q_mrc)) : 1;
>  >  	}
>  >  
>  > +	br_multicast_query_received(br, port, !ipv6_addr_any(&ip6h->saddr),
>  > +				    max_delay);
>  > +
>  >  	if (!group)
>  >  		goto out;
> 
> This addition looks suspect. max_delay looks like it could be uninitialised here.
> 
> 1178         unsigned long max_delay;
> 
> ...

fixed in David net tree


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html