netdev - Re: [Patch net-next v2 5/8] sunrpc: use generic union inet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 7 Aug 2013 09:30:46 -0400
From:	Jim Rees <rees@...ch.edu>
To:	Cong Wang <amwang@...hat.com>
Cc:	Jeff Layton <jlayton@...hat.com>, netdev@...r.kernel.org,
	"David S. Miller" <davem@...emloft.net>,
	Trond Myklebust <Trond.Myklebust@...app.com>,
	"J. Bruce Fields" <bfields@...ldses.org>, linux-nfs@...r.kernel.org
Subject: Re: [Patch net-next v2 5/8] sunrpc: use generic union inet_addr

Cong Wang wrote:

  On Tue, 2013-08-06 at 06:28 -0400, Jeff Layton wrote:
  > 
  > My question is a bit more fundamental: Why are you using this new union
  > in your patches instead of simply passing around "struct sockaddr"
  > pointers? If you did that, then you could simply replace all of the
  > rpc_* wrappers with your generic ones, since you wouldn't need to do
  > the cast to this (seemingly unnecessary) union.
  
  Because there are some places have to interpret the structure, without
  this union, they need to cast to either sockaddr_in or sockaddr_in6
  first, which is not as pretty as using a union.
  
  For example, the code in netpoll:
  
  ipv6_addr_equal(daddr, &np->local_ip.sin6.sin6_addr)
  
  without the union, it would be:
  
  struct sockaddr_in6 *addr = (struct sockaddr_in6 *) &np->local_ip;
  ipv6_addr_equal(daddr, addr->sin6_addr);

Too bad ipv6_addr_equal() doesn't take a (void *).
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html