lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 8 Aug 2013 10:21:24 +0800 From: Ying Xue <ying.xue@...driver.com> To: Erik Hugne <erik.hugne@...csson.com> CC: Eric Dumazet <eric.dumazet@...il.com>, <netdev@...r.kernel.org>, <tipc-discussion@...ts.sourceforge.net>, <jon.maloy@...csson.com> Subject: Re: skbs delivered to 'wrong' packet_type handler On 08/07/2013 11:57 PM, Erik Hugne wrote: > On Wed, Aug 07, 2013 at 06:55:43AM -0700, Eric Dumazet wrote: >> Its not ignored, quite the contrary if you look at the code : >> >> vi +3595 net/core/dev.c >> >> type = skb->protocol; >> list_for_each_entry_rcu(ptype, >> &ptype_base[ntohs(type) & PTYPE_HASH_MASK], list) { >> if (ptype->type == type && >> (ptype->dev == null_or_dev || ptype->dev == skb->dev || >> ptype->dev == orig_dev)) { >> if (pt_prev) >> ret = deliver_skb(skb, pt_prev, orig_dev); >> pt_prev = ptype; >> } >> } >> >> >> pkt->dev being set is only meaningful for packet sockets. >> >> Protocols themselves should not care. If they want to care, they must >> add their own checks. >> >> Socket API has SO_BINDTODEVICE for this purpose. >> IP layer has RP filtering. >> >> A protocol should register a single ptype with NULL dev. >> > > Very well, we'll have to fix the protocol registration and add appropriate > checks in TIPC then. Currently the usage of what TIPC registers its protocol handler into networking device is totally wrong because af_packet_priv in packet_type should be only owned by AF_PACKET socket as well as ptype->dev is set with a network device. But I am sure the patch in below link can definitely fix your met issue although it's not a final version to be submitted net-next: http://permalink.gmane.org/gmane.network.tipc.general/4159 Regards, Ying > But i fail to understand why a handler registered on the native device needs > to get the packets destined to a child vlan device (the ptype->dev == orig_dev > check). > > //E > > > -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists