lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 8 Aug 2013 16:02:30 +0530 From: Prabhakar Lad <prabhakar.csengg@...il.com> To: Sekhar Nori <nsekhar@...com> Cc: DLOS <davinci-linux-open-source@...ux.davincidsp.com>, LAK <linux-arm-kernel@...ts.infradead.org>, devicetree-discuss@...ts.ozlabs.org, LKML <linux-kernel@...r.kernel.org>, netdev@...r.kernel.org, Heiko Schocher <hs@...x.de> Subject: Re: [PATCH v3 6/6] ARM: davinci: da850: configure system configuration chip(CFGCHIP3) for emac Hi Sekhar, Sorry for the delayed response I was on leave and now back again up and running. On Wed, Jul 31, 2013 at 11:17 AM, Sekhar Nori <nsekhar@...com> wrote: > On Sunday 23 June 2013 08:30 PM, Prabhakar Lad wrote: >> From: "Lad, Prabhakar" <prabhakar.csengg@...il.com> >> >> This patch makes a common function for to configure emac and calls >> it appropriately in DT and non DT boot mode. The system configuration >> chip CFGCHIP3, controls the emac module. This patch appropriately >> configures this register for emac and sets DA850_MII_MDIO_CLKEN_PIN >> GPIO pin appropriately. >> [Snip] >> + if (rmii_enabled) >> + val |= BIT(8); >> + else >> + val &= ~BIT(8); >> + >> + /* configure the CFGCHIP3 register for RMII or MII */ >> + writel(val, cfg_chip3_base); >> + >> + ret = davinci_cfg_reg(DA850_GPIO2_6); >> + if (ret) >> + pr_warn("%s:GPIO(2,6) mux setup failed\n", __func__); >> + >> + ret = gpio_request(DA850_MII_MDIO_CLKEN_PIN, "mdio_clk_en"); >> + if (ret) { >> + pr_warn("Cannot open GPIO %d\n", DA850_MII_MDIO_CLKEN_PIN); >> + return; >> + } > > You cannot do this in SoC specific code. All boards wont use a GPIO to > choose between MII/RMII. You need to do this in a EVM specific manner. > This just means you retain the GPIO part of code in board-da850-evm.c OK > and for the DT case use a board specific GPIO node. See a similar > example in arch/arm/boot/dts/ste-nomadik-s8815.dts and how the code uses Alrite something similar to usb-s8815 node. > it in arch/arm/mach-nomadik/cpu-8815.c. > But I don't see any code to access this node in this file, can you point me to right direction ? Regards, --Prabhakar Lad -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists