[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Thu, 8 Aug 2013 12:39:09 +0200
From: Veaceslav Falico <vfalico@...hat.com>
To: netdev@...r.kernel.org
Cc: Jay Vosburgh <fubar@...ibm.com>,
Andy Gospodarek <andy@...yhouse.net>,
Patrick McHardy <kaber@...sh.net>,
"David S. Miller" <davem@...emloft.net>,
Nikolay Aleksandrov <nikolay@...hat.com>
Subject: Re: [PATCH net-next v1 0/6] bonding: remove bond->vlan_list
On Thu, Aug 08, 2013 at 12:21:03PM +0200, Veaceslav Falico wrote:
>RFC -> v1: Got some feedback from Nikolay Aleksandrov (privately), tried to
> address it, also fixed some bugs that I've found on the way. I
> think it's ready to be considered a patchset for
> review/inclusion in net-next.
I've re-sent the 1/6 (with v2), got the old version from the wrong git
branch.
>
>The aim of this patchset is to remove bond->vlan_list completely, and use
>8021q's standard functions instead of it.
>
>The patchset is on top of Nik's latest two patches:
>[net-next,v2,1/2] bonding: change the bond's vlan syncing functions with
> the standard ones
>[net-next,v2,2/2] bonding: unwind on bond_add_vlan failure
>
>
>First two patches add two helper functions to vlan code:
>
>bonding: add rcu to vlan_uses_dev() and make bond_vlan_used() use it
>
> Here we change vlan_uses_dev() to be able to work under both rtnl
> and rcu, and use it under rcu_read_lock() in bond_vlan_used().
>
>vlan: add __vlan_find_dev_next()
>
> This function takes dev and vlan_dev and returns the next vlan dev
> that uses this dev. It can be used to cycle through the vlan list,
> and not only by bonding - but by any network driver that uses its
> private vlan list.
>
>Next four patches actually convert bonding to use the new
>functions/approach and remove the vlan_list completely.
>
>This patchset solves several issues with bonding, simplify it overall,
>RCUify further and add infrastructure to anyone else who'd like to use
>8021q standard functions instead of their own vlan_list, which is quite
>common amongst network drivers currently.
>
>I'm testing it continuously currently, no issues found, will update on
>anything.
>
>CC: Jay Vosburgh <fubar@...ibm.com>
>CC: Andy Gospodarek <andy@...yhouse.net>
>CC: Patrick McHardy <kaber@...sh.net>
>CC: "David S. Miller" <davem@...emloft.net>
>CC: Nikolay Aleksandrov <nikolay@...hat.com>
>Signed-off-by: Veaceslav Falico <vfalico@...hat.com>
>
>---
> drivers/net/bonding/bond_alb.c | 48 ++++++++----
> drivers/net/bonding/bond_alb.h | 2 +-
> drivers/net/bonding/bond_main.c | 163 ++++++---------------------------------
> drivers/net/bonding/bonding.h | 16 ++--
> include/linux/if_vlan.h | 8 ++
> net/8021q/vlan.h | 6 +-
> net/8021q/vlan_core.c | 36 ++++++++-
> 7 files changed, 115 insertions(+), 164 deletions(-)
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists