[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Date: Thu, 8 Aug 2013 21:02:56 +0800
From: Yijing Wang <wangyijing@...wei.com>
To: "David S. Miller" <davem@...emloft.net>
CC: Hanjun Guo <guohanjun@...wei.com>, <jiang.liu@...wei.com>,
Yijing Wang <wangyijing@...wei.com>,
Manish Chopra <manish.chopra@...gic.com>,
Sony Chacko <sony.chacko@...gic.com>,
Rajesh Borundia <rajesh.borundia@...gic.com>,
<netdev@...r.kernel.org>
Subject: [PATCH 09/16] netxen: clean up unnecessary MSI/MSI-X capability find
PCI core will initialize device MSI/MSI-X capability in
pci_msi_init_pci_dev(). So device driver should use
pci_dev->msi_cap/msix_cap to determine whether the device
support MSI/MSI-X instead of using
pci_find_capability(pci_dev, PCI_CAP_ID_MSI/MSIX).
Access to PCIe device config space again will consume more time.
Signed-off-by: Yijing Wang <wangyijing@...wei.com>
Cc: Manish Chopra <manish.chopra@...gic.com>
Cc: Sony Chacko <sony.chacko@...gic.com>
Cc: Rajesh Borundia <rajesh.borundia@...gic.com>
Cc: netdev@...r.kernel.org
---
.../net/ethernet/qlogic/netxen/netxen_nic_main.c | 8 +++-----
1 files changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/net/ethernet/qlogic/netxen/netxen_nic_main.c b/drivers/net/ethernet/qlogic/netxen/netxen_nic_main.c
index c401b0b..1046e94 100644
--- a/drivers/net/ethernet/qlogic/netxen/netxen_nic_main.c
+++ b/drivers/net/ethernet/qlogic/netxen/netxen_nic_main.c
@@ -459,16 +459,14 @@ static void netxen_pcie_strap_init(struct netxen_adapter *adapter)
static void netxen_set_msix_bit(struct pci_dev *pdev, int enable)
{
u32 control;
- int pos;
- pos = pci_find_capability(pdev, PCI_CAP_ID_MSIX);
- if (pos) {
- pci_read_config_dword(pdev, pos, &control);
+ if (pdev->msix_cap) {
+ pci_read_config_dword(pdev, pdev->msix_cap, &control);
if (enable)
control |= PCI_MSIX_FLAGS_ENABLE;
else
control = 0;
- pci_write_config_dword(pdev, pos, control);
+ pci_write_config_dword(pdev, pdev->msix_cap, control);
}
}
--
1.7.1
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists