netdev - Re: [Patch net-next] vxlan: fix a regression of igmp join

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 09 Aug 2013 11:42:34 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	amwang@...hat.com
Cc:	netdev@...r.kernel.org, stephen@...workplumber.org
Subject: Re: [Patch net-next] vxlan: fix a regression of igmp join

From: Cong Wang <amwang@...hat.com>
Date: Wed,  7 Aug 2013 16:35:45 +0800

> From: Cong Wang <amwang@...hat.com>
> 
> This is a regression introduced by:
> 
> 	commit 3fc2de2faba387218bdf9dbc6b13f513ac3b060a
> 	Author: stephen hemminger <stephen@...workplumber.org>
> 	Date:   Thu Jul 18 08:40:15 2013 -0700
> 
> 	    vxlan: fix igmp races
> 
> Before this commit, the old code was:
> 
>        if (vxlan_group_used(vn, vxlan->default_dst.remote_ip))
>                ip_mc_join_group(sk, &mreq);
>        else
>                ip_mc_leave_group(sk, &mreq);
> 
> therefore we shoud check vxlan_group_used(), not its opposite,
> for igmp_join.
> 
> Cc: Stephen Hemminger <stephen@...workplumber.org>
> Cc: David S. Miller <davem@...emloft.net>
> Signed-off-by: Cong Wang <amwang@...hat.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html