lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 12 Aug 2013 11:16:34 +0100 From: William Manley <william.manley@...view.com> To: <netdev@...r.kernel.org>, <bcrl@...ck.org>, <yoshfuji@...ux-ipv6.org> Subject: Re: [PATCH net-next] ipv6: make unsolicited report intervals configurable for mld On 12/08/13 02:48, Hannes Frederic Sowa wrote: > Commit cab70040dfd95ee32144f02fade64f0cb94f31a0 ("net: igmp: > Reduce Unsolicited report interval to 1s when using IGMPv3") and > 2690048c01f32bf45d1c1e1ab3079bc10ad2aea7 ("net: igmp: Allow user-space > configuration of igmp unsolicited report interval") by William Manley made > igmp unsolicited report intervals configurable per interface and corrected > the interval of unsolicited igmpv3 report messages resendings to 1s. > > Same needs to be done for IPv6: > > MLDv1 (RFC2710 7.10.): 10 seconds > MLDv2 (RFC3810 9.11.): 1 second > > Both intervals are configurable via new procfs knobs > mldv1_unsolicited_report_interval and mldv2_unsolicited_report_interval. > > Cc: William Manley<william.manley@...view.com> > Cc: Benjamin LaHaise<bcrl@...ck.org> > Cc: YOSHIFUJI Hideaki<yoshfuji@...ux-ipv6.org> > Signed-off-by: Hannes Frederic Sowa<hannes@...essinduktion.org> Thanks for this. I'd meant to save you the bother. > diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c > index 7fd8572..158c5e1 100644 > --- a/net/ipv6/addrconf.c > +++ b/net/ipv6/addrconf.c > @@ -177,6 +177,8 @@ static struct ipv6_devconf ipv6_devconf __read_mostly = { > .accept_redirects = 1, > .autoconf = 1, > .force_mld_version = 0, > + .mldv1_unsolicited_report_interval = 10*HZ, I think you want spaces around that * operator. > + .mldv2_unsolicited_report_interval = HZ, > .dad_transmits = 1, > .rtr_solicits = MAX_RTR_SOLICITATIONS, > .rtr_solicit_interval = RTR_SOLICITATION_INTERVAL, > @@ -211,6 +213,9 @@ static struct ipv6_devconf ipv6_devconf_dflt __read_mostly = { > .accept_ra = 1, > .accept_redirects = 1, > .autoconf = 1, > + .force_mld_version = 0, Is this a tidyup or does it make a functional difference to this patch? I suspect the former but I thought I'd check for my own understanding. > + .mldv1_unsolicited_report_interval = 10*HZ, Spaces here as well Thanks Will -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists