netdev - tun always return NETDEV_TX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 13 Aug 2013 10:39:02 -0400
From:	Yannick Koehler <yannick@...hler.name>
To:	netdev@...r.kernel.org
Subject: tun always return NETDEV_TX_OK, why?

Hello,

  I hit a problem recently with the tun interface, it looks like when
this interface reach its txqueuelen it will then drop the packet and
return NETDEV_TX_OK unconditionally.

 That, from my little understanding of the netdev framework, appears
to be wrong and will simply eat up any pending buffer and discard them
until the queue frees itself.  That seems to be against the flow
control design in the tx queue system of the kernel.

  So, is this a bug or a misunderstanding?  Would it be ok for tun to
return NETDEV_TX_BUSY when the txqueuelen is reach and call
netif_stop_queue() so that the layer above stop sending frame to this
interface until it can cope it's current queue content?

-- 
Yannick Koehler
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html