netdev - Re: [PATCH net-next 1/2] net-next: sundance: Add netconsole logging support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 17 Aug 2013 03:46:49 +0400
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Denis Kirjanov <kda@...ux-powerpc.org>
CC:	netdev@...r.kernel.org, davem@...emloft.net
Subject: Re: [PATCH net-next 1/2] net-next: sundance: Add netconsole logging
 support

Hello.

On 08/16/2013 09:00 PM, Denis Kirjanov wrote:

    I'd rather name the patch "sundance: add netpoll support". "net-next:" 
shouldn't be there twice definitely.

> Signed-off-by: Denis Kirjanov <kda@...ux-powerpc.org>
> ---
>   drivers/net/ethernet/dlink/sundance.c | 14 ++++++++++++++
>   1 file changed, 14 insertions(+)

> diff --git a/drivers/net/ethernet/dlink/sundance.c b/drivers/net/ethernet/dlink/sundance.c
> index 50d9c63..2688a84 100644
> --- a/drivers/net/ethernet/dlink/sundance.c
> +++ b/drivers/net/ethernet/dlink/sundance.c
[...]
> @@ -480,6 +491,9 @@ static const struct net_device_ops netdev_ops = {
>   	.ndo_change_mtu		= change_mtu,
>   	.ndo_set_mac_address 	= sundance_set_mac_addr,
>   	.ndo_validate_addr	= eth_validate_addr,
> +#ifdef CONFIG_NET_POLL_CONTROLLER
> +	.ndo_poll_controller = sundance_poll_controller,

    Could you align = here with the reset of initializers?

> +#endif

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html