netdev - Re: [PATCH next] drivers: net: can: c_can: add type cast from 'unsigned int' to 'int'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 21 Aug 2013 11:45:02 +0200
From:	Marc Kleine-Budde <mkl@...gutronix.de>
To:	Chen Gang <gang.chen@...anux.com>
CC:	wg@...ndegger.com, anilkumar@...com,
	Tony Lindgren <tony@...mide.com>, jg1.han@...sung.com,
	David Miller <davem@...emloft.net>, linux-can@...r.kernel.org,
	netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH next] drivers: net: can: c_can: add type cast from 'unsigned
 int' to 'int'

On 08/21/2013 11:09 AM, Chen Gang wrote:
> 'priv->instance' may less than zero, so need a type cast, the related
> warnings (allmodconfig, "EXTRA_CFLAGS=-W"):
> 
>   drivers/net/can/c_can/c_can_platform.c:198:3: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]

Tnx, I've tweaked the commit message a bit, will send a v2.

Marc
-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


Download attachment "signature.asc" of type "application/pgp-signature" (260 bytes)