netdev - Re: [RFC] b44: use phylib

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 24 Aug 2013 16:32:48 +0200
From:	Hauke Mehrtens <hauke@...ke-m.de>
To:	Joe Perches <joe@...ches.com>
CC:	zambrano@...adcom.com, netdev@...r.kernel.org,
	Florian Fainelli <florian@...nwrt.org>
Subject: Re: [RFC] b44: use phylib

On 08/24/2013 01:10 AM, Joe Perches wrote:
> On Sat, 2013-08-24 at 00:56 +0200, Hauke Mehrtens wrote:
>> This splits the driver into the mac and a phy driver. On routers where
>> this driver is used we have a switch which implements a phy and can be
>> controlled by a phy driver.
> 
> trivial comments only...

I will extend this.

>> diff --git a/drivers/net/ethernet/broadcom/b44.c b/drivers/net/ethernet/broadcom/b44.c
> []
>> +static void b44_adjust_link(struct net_device *dev)
>> +{
>> +	struct b44 *bp = netdev_priv(dev);
>> +	struct phy_device *phydev = bp->phydev;
>> +	int status_changed = 0;
> 
> bool?

Thanks, I will change this.

>> +static int b44_mii_probe(struct net_device *dev)
>> +{
> []
>> +	if (IS_ERR(phydev)) {
>> +		netdev_err(dev, "could not attach PHY: %s", phy_id);
> 
> missing newline?

Fixed.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html