netdev - Re: [PATCH] tipc: set sk_err correctly when connection fails

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 27 Aug 2013 17:18:41 +0200
From:	Erik Hugne <erik.hugne@...csson.com>
To:	Paul Gortmaker <paul.gortmaker@...driver.com>
CC:	<netdev@...r.kernel.org>, <jon.maloy@...csson.com>,
	<ying.xue@...driver.com>, <tipc-discussion@...ts.sourceforge.net>,
	<nhan.tt.vo@...tech.com.au>
Subject: Re: [PATCH] tipc: set sk_err correctly when connection fails

On Tue, Aug 27, 2013 at 09:20:23AM -0400, Paul Gortmaker wrote:
> What was the high level user visible symptom in this case?
> Stalled connections or ... ?

Should the connect fail, if the publication/server is unavailable or some other
error. The connect() call returns the error code directly (as a positive value).

[...]
socket(0x1e /* PF_??? */, SOCK_SEQPACKET, 0) = 3
setsockopt(3, 0x10f /* SOL_?? */, 129, [0], 4) = 0
setsockopt(3, 0x10f /* SOL_?? */, 127, [0], 4) = 0
connect(3, {sa_family=0x1e /* AF_??? */, sa_data="\2\1\322\4\0\0\322\4\0\0\0\0\0\0"}, 16) = 111
sendto(3, "\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0"..., 66000, 0, NULL, 0) = -1 EPIPE (Broken pipe)

In the strace above, error checking was done as:
if (connect(fd,.....) < 0)
    perror("connect");

//E
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html