| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Wed, 28 Aug 2013 02:26:28 +0000 From: "Brown, Aaron F" <aaron.f.brown@...el.com> To: Jiri Pirko <jiri@...nulli.us>, "Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com> CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "davem@...emloft.net" <davem@...emloft.net>, "stephen@...workplumber.org" <stephen@...workplumber.org>, "Narendra_K@...l.com" <Narendra_K@...l.com>, "bhutchings@...arflare.com" <bhutchings@...arflare.com>, "or.gerlitz@...il.com" <or.gerlitz@...il.com>, "Wyborny, Carolyn" <carolyn.wyborny@...el.com>, "Rose, Gregory V" <gregory.v.rose@...el.com>, "vyasevic@...hat.com" <vyasevic@...hat.com>, "amwang@...hat.com" <amwang@...hat.com>, "johannes@...solutions.net" <johannes@...solutions.net> Subject: RE: [patch net-next v6 4/4] igb/igbvf: implement ndo_get_phys_port_id Sorry, I was out sick towards the end of last week and playing catch up for the last few days... Info inline. > From: Jiri Pirko [mailto:jiri@...nulli.us] > Sent: Thursday, August 22, 2013 6:10 AM > To: Kirsher, Jeffrey T > Cc: Brown, Aaron F; netdev@...r.kernel.org; davem@...emloft.net; > stephen@...workplumber.org; Narendra_K@...l.com; > bhutchings@...arflare.com; or.gerlitz@...il.com; Wyborny, Carolyn; Rose, > Gregory V; vyasevic@...hat.com; amwang@...hat.com; > johannes@...solutions.net > Subject: Re: [patch net-next v6 4/4] igb/igbvf: implement > ndo_get_phys_port_id > > Thu, Aug 22, 2013 at 12:39:10PM CEST, jeffrey.t.kirsher@...el.com wrote: > >On Mon, 2013-07-29 at 18:16 +0200, Jiri Pirko wrote: > >> igb driver generated random number which will identify physical port. > >> This id is available via ndo_get_phys_port_id directly on igb netdev. > >> Also, id is passed to igbvf using mailbox. After that, it is > >> available via ndo_get_phys_port_id on igbvf netdev as well. > >> > >> Signed-off-by: Jiri Pirko <jiri@...nulli.us> > >> --- > >> drivers/net/ethernet/intel/igb/e1000_mbx.h | 1 + > >> drivers/net/ethernet/intel/igb/igb.h | 3 +++ > >> drivers/net/ethernet/intel/igb/igb_main.c | 37 > >> ++++++++++++++++++++++++++++- > >> drivers/net/ethernet/intel/igbvf/igbvf.h | 4 ++++ > >> drivers/net/ethernet/intel/igbvf/mbx.h | 1 + > >> drivers/net/ethernet/intel/igbvf/netdev.c | 38 > >> ++++++++++++++++++++++++++++++ > >> drivers/net/ethernet/intel/igbvf/vf.c | 34 > >> ++++++++++++++++++++++++++ > >> drivers/net/ethernet/intel/igbvf/vf.h | 1 + > >> 8 files changed, 118 insertions(+), 1 deletion(-) > > > >Jiri- > > > >Validation ran into a couple of issues with this patch. Here is what > >Aaron found when testing this patch... > > Interesting. So since igbvf_refresh_ppid() is called from igbvf_reset() > and igbvf_probe(), I believed that is enough. Looks like perm_addr getting > works in similar way. Can you please check if perm_addr is set correctly > in the same time reading phys_port_id gives -EOPNOTSUPP? By perm_addr do you mean the MAC Address of the vf? Yes, it is set up (and I can view it vi ip link or sysconfig) when I see the op not supported message (after I fi vfs via sysfs, before bringing the vf interface up or reloading igbvf.) > > > > > >Aaron Brown wrote: > >I think I have to fail this, it seems to have an issue with > >initialization. When I first create a vf via sysfs the pys_port_id > >file is created along with the other sysfs files for the vf, however an > >attempt to cat out the value returns " Operation not supported". At > >this point the vf is still down, if I bring it up (or simply unload / > >reload the igbvf driver) I can then cat the file successfully and the > >vf interface phys_port_id matches the phys_port_id of the pf. This is > >testing from bare metal, a console session showing this behavior > >follows: > > > >u1304:[0]/sys> find . -iname phys_port_id > >./devices/pci0000:00/0000:00:01.0/0000:07:00.0/net/eth0/phys_port_id > >./devices/pci0000:00/0000:00:01.0/0000:07:00.1/net/eth1/phys_port_id > >./devices/virtual/net/sit0/phys_port_id > >./devices/virtual/net/lo/phys_port_id > >u1304:[0]/sys> cat > >devices/pci0000:00/0000:00:01.0/0000:07:00.0/net/eth0/phys_port_id > >5ece9fbd9cd51546982e15c1f2c11e25 > >u1304:[0]/sys> > > > >So far so good, now make a few vfs and check for new phys_port_id sysfs > files. > > > >u1304:[0]/sys> find . -iname sriov_numvfs > >./devices/pci0000:00/0000:00:01.0/0000:07:00.0/sriov_numvfs > >./devices/pci0000:00/0000:00:01.0/0000:07:00.1/sriov_numvfs > >u1304:[0]/sys> echo 2 > > devices/pci0000:00/0000:00:01.0/0000:07:00.0/sriov_numvfs > >u1304:[0]/sys> find . -iname phys_port_id > ./devices/pci0000:00/0000:00:01.0/0000:07:00.0/net/eth0/phys_port_id > >./devices/pci0000:00/0000:00:01.0/0000:07:00.1/net/eth1/phys_port_id > >./devices/pci0000:00/0000:00:01.0/0000:07:10.0/net/eth2/phys_port_id > >./devices/pci0000:00/0000:00:01.0/0000:07:10.2/net/eth3/phys_port_id > >./devices/virtual/net/sit0/phys_port_id > >./devices/virtual/net/lo/phys_port_id > >u1304:[0]/sys> > > > >The first vf is eth2, attempt to cat out it's phys_port_id > > > >u1304:[0]/sys> cat > >./devices/pci0000:00/0000:00:01.0/0000:07:10.0/net/eth2/phys_port_id > >cat: > >./devices/pci0000:00/0000:00:01.0/0000:07:10.0/net/eth2/phys_port_id: > >Operation not supported u1304:[0]/sys> > > > >But, if I bring the interface up (or unload / load the igbvf driver) I > then am able to cat the phys_port_id of the vf and it matches the > phys_port_id of the physical interface. > > > >u1304:[0]/sys> ifconfig eth2 u1304-2 > >u1304:[0]/sys> cat > >./devices/pci0000:00/0000:00:01.0/0000:07:10.0/net/eth2/phys_port_id > >5ece9fbd9cd51546982e15c1f2c11e25 > >u1304:[0]/sys> > -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists