lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 2 Sep 2013 02:09:56 +0000 From: Li Frank-B20596 <B20596@...escale.com> To: Duan Fugang-B38611 <B38611@...escale.com>, David Miller <davem@...emloft.net> CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "bhutchings@...arflare.com" <bhutchings@...arflare.com>, "l.stach@...gutronix.de" <l.stach@...gutronix.de> Subject: RE: [PATCH] net: fec: fix the error to get the previous BD entry > > Due to get tx & rx previous description use the same function > fec_enet_get_prevdesc(). If put the logic into fec_enet_get_prevdesc(), I > think it is better to split the function to > fec_enet_get_tx_prevdesc(),fec_enet_get_rx_prevdesc(). > > If you agree it, I will submit one patch to do it. It doesn't looks good to split to two functions. Can we use if (p == fep->tx_base || p == fep->rx_base) to check if get first entry of queue? Best regards Frank Li > > Thanks, > Andy -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists