| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Tue, 03 Sep 2013 22:14:48 -0400 (EDT) From: David Miller <davem@...emloft.net> To: claudiu.manoil@...escale.com Cc: netdev@...r.kernel.org, eric.dumazet@...il.com Subject: Re: [PATCH][net-next] gianfar: Fix reported number of sent bytes to BQL From: Claudiu Manoil <claudiu.manoil@...escale.com> Date: Fri, 30 Aug 2013 15:01:15 +0300 > Fix the amount of sent bytes reported to BQL by reporting the > number of bytes on wire in the xmit routine, and recording that > value for each skb in order to be correctly confirmed on Tx > confirmation cleanup. > > Reporting skb->len to BQL just before exiting xmit is not correct > due to possible insertions of TOE block and alignment bytes in the > skb->data, which are being stripped off by the controller before > transmission on wire. This led to mismatch of (incorrectly) > reported bytes to BQL b/w xmit and Tx confirmation, resulting in > Tx timeout firing, for the h/w tx timestamping acceleration case. > > There's no easy way to obtain the number of bytes on wire in the Tx > confirmation routine, so skb->cb is used to convey that information > from xmit to Tx confirmation, for now (as proposed by Eric). Revived > the currently unused GFAR_CB() construct for that purpose. > > Signed-off-by: Claudiu Manoil <claudiu.manoil@...escale.com> Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists