lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 12 Sep 2013 14:16:01 +0100 From: Ben Hutchings <bhutchings@...arflare.com> To: David Miller <davem@...emloft.net> CC: <jg1.han@...sung.com>, <sergei.shtylyov@...entembedded.com>, <netdev@...r.kernel.org> Subject: Re: [PATCH 20/52] net: fealnx: remove unnecessary pci_set_drvdata() On Thu, 2013-09-12 at 03:36 -0400, David Miller wrote: > From: Jingoo Han <jg1.han@...sung.com> > Date: Thu, 12 Sep 2013 14:49:56 +0900 > > > On Thursday, September 12, 2013 2:25 PM, David Miller wrote: > >> On Thu, 12 Sep 2013 09:11:01 +0900, Jingoo Han wrote: > >> > Would you let know the reason not to add coding style fixes? > >> > >> They should be made seperately so that the individual changes > >> can be reviewed more easily and without unnecessary unrelated > >> changes mixed in. > > > > OK, I see. :-) > > Thank you for your answer. > > Then, I will send V2 patch soon. > > Please do not submit such a huge patch series in the future. > > Anything more than 16 patches at a time is not reasonable and > overloads reviewer's capacity to look at your changes. Given that this is the same trivial change applied to many different drivers, is it really worthwhile to break it up into a patch per driver? Ben. -- Ben Hutchings, Staff Engineer, Solarflare Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists