lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 19 Sep 2013 09:56:09 -0500 From: Simon Horman <horms@...ge.net.au> To: Jesse Gross <jesse@...ira.com> Cc: "dev@...nvswitch.org" <dev@...nvswitch.org>, netdev <netdev@...r.kernel.org>, Ravi K <rkerur@...il.com>, Isaku Yamahata <yamahata@...inux.co.jp>, Pravin B Shelar <pshelar@...ira.com>, Joe Stringer <joe@...d.net.nz> Subject: Re: [PATCH v2.39 6/7] datapath: Break out deacceleration portion of vlan_push On Fri, Sep 13, 2013 at 03:07:12PM -0700, Jesse Gross wrote: > On Mon, Sep 9, 2013 at 12:20 AM, Simon Horman <horms@...ge.net.au> wrote: > > diff --git a/datapath/actions.c b/datapath/actions.c > > index 30ea1d2..6741d81 100644 > > --- a/datapath/actions.c > > +++ b/datapath/actions.c > > @@ -105,22 +105,29 @@ static int pop_vlan(struct sk_buff *skb) > > return 0; > > } > > > > -static int push_vlan(struct sk_buff *skb, const struct ovs_action_push_vlan *vlan) > > +/* push down current VLAN tag */ > > +static struct sk_buff *put_vlan(struct sk_buff *skb) > > This never changes the skb, right? Can we simplify things and just > return an error code? Yes. I'm not sure what I was thinking when I chose not to do that but I will change things around as you suggest. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists