netdev - Re: Bug - regression - Via velocity interface coming up freezes kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 23 Sep 2013 08:29:31 +0200
From:	Dirk Kraft <dirk.kraft@...il.com>
To:	Francois Romieu <romieu@...zoreil.com>
Cc:	netdev@...r.kernel.org, Julia Lawall <Julia.Lawall@...6.fr>
Subject: Re: Bug - regression - Via velocity interface coming up freezes kernel

Hi

On Mon, Sep 23, 2013 at 12:11 AM, Francois Romieu <romieu@...zoreil.com> wrote:
[...]
> You can try this one as a wild guess before I have more time to analyze.

By applying the below patch to 3.11-rc1 the problem is gone.

I was only able to do a short test. Could not say if this has any side effects.

Thanks,
Dirk

>
> diff --git a/drivers/net/ethernet/via/via-velocity.c b/drivers/net/ethernet/via/via-velocity.c
> index d022bf9..64c42be 100644
> --- a/drivers/net/ethernet/via/via-velocity.c
> +++ b/drivers/net/ethernet/via/via-velocity.c
> @@ -2172,16 +2172,13 @@ static int velocity_poll(struct napi_struct *napi, int budget)
>         unsigned int rx_done;
>         unsigned long flags;
>
> -       spin_lock_irqsave(&vptr->lock, flags);
>         /*
>          * Do rx and tx twice for performance (taken from the VIA
>          * out-of-tree driver).
>          */
> -       rx_done = velocity_rx_srv(vptr, budget / 2);
> -       velocity_tx_srv(vptr);
> -       rx_done += velocity_rx_srv(vptr, budget - rx_done);
> +       rx_done = velocity_rx_srv(vptr, budget);
> +       spin_lock_irqsave(&vptr->lock, flags);
>         velocity_tx_srv(vptr);
> -
>         /* If budget not fully consumed, exit the polling mode */
>         if (rx_done < budget) {
>                 napi_complete(napi);
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html