lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 24 Sep 2013 11:16:56 -0400 (EDT) From: David Miller <davem@...hat.com> To: eric.dumazet@...il.com Cc: netdev@...r.kernel.org, ncardwell@...gle.com, ycheng@...gle.com, vanj@...gle.com Subject: Re: [PATCH net-next] tcp: fix dynamic right sizing From: Eric Dumazet <eric.dumazet@...il.com> Date: Fri, 20 Sep 2013 13:56:58 -0700 > Dynamic Right Sizing (DRS) is supposed to open TCP receive window > automatically, but suffers from two bugs, presented by order > of importance. > > 1) tcp_rcv_space_adjust() fix : > > Using twice the last received amount is very pessimistic, > because it doesn't allow fast recovery or proper slow start > ramp up, if sender wants to increase cwin by 100% every RTT. > > copied = bytes received in previous RTT > > 2*copied = bytes we expect to receive in next RTT > > 4*copied = bytes we need to advertise in rwin at end of next RTT > > DRS is one RTT late, it needs a 4x factor. > > If sender is not using ABC, and increases cwin by 50% every rtt, > then we needed 1.5*1.5 = 2.25 factor. > This is probably why this bug was not really noticed. > > 2) There is no window adjustment after first RTT. DRS triggers only > after the second RTT. > DRS needs two RTT to initialize, so tcp_fixup_rcvbuf() should setup > sk_rcvbuf to allow proper window grow for first two RTT. > > This patch increases TCP efficiency particularly for large RTT flows > when autotuning is used at the receiver, and more particularly > in presence of packet losses. > > Signed-off-by: Eric Dumazet <edumazet@...gle.com> > Signed-off-by: Neal Cardwell <ncardwell@...gle.com> > Signed-off-by: Yuchung Cheng <ycheng@...gle.com> > Cc: Van Jacobson <vanj@...gle.com> Looks good, applied, thanks Eric. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists