lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 02 Oct 2013 05:03:06 -0700 From: Eric Dumazet <eric.dumazet@...il.com> To: Nikolay Aleksandrov <nikolay@...hat.com> Cc: netdev@...r.kernel.org, davem@...emloft.net, andy@...yhouse.net, fubar@...ibm.com, vfalico@...hat.com Subject: Re: [PATCH net-next v5 2/3] bonding: modify the old and add new xmit hash policies On Wed, 2013-10-02 at 13:39 +0200, Nikolay Aleksandrov wrote: > This patch adds two new hash policy modes which use skb_flow_dissect: > 3 - Encapsulated layer 2+3 > 4 - Encapsulated layer 3+4 > There should be a good improvement for tunnel users in those modes. > It also changes the old hash functions to: > hash ^= (__force u32)flow.dst ^ (__force u32)flow.src; > hash ^= (hash >> 16); > hash ^= (hash >> 8); > > Where hash will be initialized either to L2 hash, that is > SRCMAC[5] XOR DSTMAC[5], or to flow->ports which should be extracted > from the upper layer. Flow's dst and src are also extracted based on the > xmit policy either directly from the buffer or by using skb_flow_dissect, > but in both cases if the protocol is IPv6 then dst and src are obtained by > ipv6_addr_hash() on the real addresses. In case of a non-dissectable > packet, the algorithms fall back to L2 hashing. > The bond_set_mode_ops() function is now obsolete and thus deleted > because it was used only to set the proper hash policy. Also we trim a > pointer from struct bonding because we no longer need to keep the hash > function, now there's only a single hash function - bond_xmit_hash that > works based on bond->params.xmit_policy. > > The hash function and skb_flow_dissect were suggested by Eric Dumazet. > The layer names were suggested by Andy Gospodarek, because I suck at > semantics. > > Signed-off-by: Nikolay Aleksandrov <nikolay@...hat.com> > --- Very nice, thanks ! Acked-by: Eric Dumazet <edumazet@...gle.com> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists