| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Mon, 07 Oct 2013 15:45:36 -0700 From: ebiederm@...ssion.com (Eric W. Biederman) To: David Miller <davem@...emloft.net> Cc: fruggeri@...stanetworks.com, netdev@...r.kernel.org Subject: Re: [PATCH] net: Separate the close_list and the unreg_list v2 David Miller <davem@...emloft.net> writes: > From: ebiederm@...ssion.com (Eric W. Biederman) > Date: Sat, 05 Oct 2013 19:26:05 -0700 > >> >> Separate the unreg_list and the close_list in dev_close_many preventing >> dev_close_many from permuting the unreg_list. The permutations of the >> unreg_list have resulted in cases where the loopback device is accessed >> it has been freed in code such as dst_ifdown. Resulting in subtle memory >> corruption. >> >> This is the second bug from sharing the storage between the close_list >> and the unreg_list. The issues that crop up with sharing are >> apparently too subtle to show up in normal testing or usage, so let's >> forget about being clever and use two separate lists. >> >> v2: Make all callers pass in a close_list to dev_close_many >> >> Signed-off-by: "Eric W. Biederman" <ebiederm@...ssion.com> >> --- >> >> Sending the complete diff because this version is actually more >> readable and more obviously correct. > > I'll apply this, thanks Eric. Thanks. It is good to see this getting sorted out. Eric -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists