netdev - Re: [PATCH net v2] be2net: Warn users of possible broken functionality on BE2 cards with very old FW versions with latest driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 07 Oct 2013 09:44:29 -0700
From:	Joe Perches <joe@...ches.com>
To:	David Miller <davem@...emloft.net>
Cc:	somnath.kotur@...lex.com, netdev@...r.kernel.org
Subject: Re: [PATCH net v2] be2net: Warn users of possible broken
 functionality on BE2 cards with very old FW versions with latest driver

On Mon, 2013-10-07 at 12:31 -0400, David Miller wrote:
> From: Somnath Kotur <somnath.kotur@...lex.com>
> Date: Thu, 3 Oct 2013 15:34:29 +0530
> > +     if (BE2_chip(adapter) && memcmp(adapter->fw_ver, "4.", 2) < 0) {
> > +             dev_err(dev, "Firmware version is too old.IRQs may not work\n");
> 
> So many grammatical mistakes in one line.
> 
> First sentence got a period, second one did not.
> 
> Missing space between period and second sentence.

Periods are unnecessary here.
Just use a comma or a dash.

Also, it might be nicer to show the current firmware version too.

Maybe:

		dev_err(dev, "Firmware version is '%s' - Version 5 or higher is required for properly functional IRQs\n",
			adapter->fw_ver);

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html