lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 9 Oct 2013 11:41:17 -0400 From: Tejun Heo <tj@...nel.org> To: Alexander Gordeev <agordeev@...hat.com> Cc: Benjamin Herrenschmidt <benh@...nel.crashing.org>, Ben Hutchings <bhutchings@...arflare.com>, linux-kernel@...r.kernel.org, Bjorn Helgaas <bhelgaas@...gle.com>, Ralf Baechle <ralf@...ux-mips.org>, Michael Ellerman <michael@...erman.id.au>, Martin Schwidefsky <schwidefsky@...ibm.com>, Ingo Molnar <mingo@...hat.com>, Dan Williams <dan.j.williams@...el.com>, Andy King <acking@...are.com>, Jon Mason <jon.mason@...el.com>, Matt Porter <mporter@...nel.crashing.org>, linux-pci@...r.kernel.org, linux-mips@...ux-mips.org, linuxppc-dev@...ts.ozlabs.org, linux390@...ibm.com, linux-s390@...r.kernel.org, x86@...nel.org, linux-ide@...r.kernel.org, iss_storagedev@...com, linux-nvme@...ts.infradead.org, linux-rdma@...r.kernel.org, netdev@...r.kernel.org, e1000-devel@...ts.sourceforge.net, linux-driver@...gic.com, Solarflare linux maintainers <linux-net-drivers@...arflare.com>, "VMware, Inc." <pv-drivers@...are.com>, linux-scsi@...r.kernel.org Subject: Re: [PATCH RFC 00/77] Re-design MSI/MSI-X interrupts enablement pattern Hello, On Tue, Oct 08, 2013 at 02:22:16PM +0200, Alexander Gordeev wrote: > If we talk about pSeries quota, then the current pSeries pci_enable_msix() > implementation is racy internally and could fail if the quota went down > *while* pci_enable_msix() is executing. In this case the loop will have to > exit rather than retry with a lower number (what number?). Ah, okay, so that one is already broken. > In this regard the new scheme does not bring anything new and relies on > the fact this race does not hit and therefore does not worry. > > If we talk about quota as it has to be, then yes - the loop scheme seems > more preferable. > > Overall, looks like we just need to fix the pSeries implementation, > if the guys want it, he-he :) If we can't figure out a better interface for the retry case, I think what can really help is having a simple interface for the simpler cases. > > The problem case is where multiple msi(x) allocation fails completely > > because the global limit went down before inquiry and allocation. In > > the loop based interface, it'd retry with the lower number. > > I am probably missing something here. If the global limit went down before > inquiry then the inquiry will get what is available and try to allocate with > than number. Oh, I should have written between inquiry and allocation. Sorry. Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists