lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 10 Oct 2013 07:08:44 -0500 From: Dan Murphy <dmurphy@...com> To: Ming Lei <tom.leiming@...il.com> CC: Steve Glendinning <steve.glendinning@...well.net>, Network Development <netdev@...r.kernel.org>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, linux-usb <linux-usb@...r.kernel.org>, <mugunthanvnm@...com> Subject: Re: [PATCH] usbnet: smsc95xx: Add device tree input for MAC address Ming On 10/07/2013 06:42 AM, Ming Lei wrote: > On Mon, Oct 7, 2013 at 1:31 AM, Dan Murphy <dmurphy@...com> wrote: >> On 10/06/2013 10:05 AM, Ming Lei wrote: >>> On Sat, Oct 5, 2013 at 2:25 AM, Dan Murphy <dmurphy@...com> wrote: >>>> If the smsc95xx does not have a valid MAC address stored within >>>> the eeprom then a random number is generated. The MAC can also >>>> be set by uBoot but the smsc95xx does not have a way to read this. >>>> >>>> Create the binding for the smsc95xx so that uBoot can set the MAC >>>> and the code can retrieve the MAC from the modified DTB file. >>> Suppose there are two smsc95xx usbnet devices connected to usb bus, and >>> one is built-in, another is hotplug device, can your patch handle the situation >>> correctly? >> Look at this line in the patch below >> >> sprintf(of_name, "%s%i", SMSC95XX_OF_NAME, dev->udev->dev.id); >> >> I am appending the dev ID of the device to the of_name here. As long as init_mac_address is called, the dev.id and the uBoot >> entry match then yes. > Currently, non-root-hub usb device is created and added into usb bus without > any platform(device tree) knowledge, so you can't expect the match here. > > Also not mention the two smsc95xx devices may attach to two different > usb host controllers(buses). > > Thanks, You are correct I don't expect a match for PnP devices only devices that are hard wired. After thinking of it I should move the OF code below the EEPROM code as the EEPROM should take preference over the DT code. I will need to post V2 for that. Dan -- ------------------ Dan Murphy -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists