lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Wed, 23 Oct 2013 14:03:43 -0700
From:	Stephen Hemminger <stephen@...workplumber.org>
To:	Alexei Starovoitov <ast@...mgrid.com>
Cc:	"David S. Miller" <davem@...emloft.net>,
	Nicolas Dichtel <nicolas.dichtel@...nd.com>,
	Cong Wang <amwang@...hat.com>, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] fix rtnl notification in atomic context

On Wed, 23 Oct 2013 11:32:41 -0700
Alexei Starovoitov <ast@...mgrid.com> wrote:

> +
> +void rtmsg_ifinfo(int type, struct net_device *dev, unsigned int change)
> +{
> +	__rtmsg_ifinfo(type, dev, change, GFP_KERNEL);
> +}
>  EXPORT_SYMBOL(rtmsg_ifinfo);
>  
>  static int nlmsg_populate_fdb_fill(struct sk_buff *skb,
> -- 

Why add another wrapper function? I think it cleaner to just change all the
callers to use the correct gfp flags.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ