netdev - Re: [PATCH net-next 2/3] tipc: message reassembly using fragment chain

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 28 Oct 2013 01:07:37 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	jon.maloy@...csson.com
Cc:	netdev@...r.kernel.org, paul.gortmaker@...driver.com,
	erik.hugne@...csson.com, ying.xue@...driver.com, maloy@...jonn.com,
	tipc-discussion@...ts.sourceforge.net
Subject: Re: [PATCH net-next 2/3] tipc: message reassembly using fragment
 chain

From: Jon Maloy <jon.maloy@...csson.com>
Date: Sat, 26 Oct 2013 14:41:02 -0400

> +			int ret = tipc_link_recv_fragment(
> +					&node->bclink.reasm_head,
> +					&node->bclink.reasm_tail,
> +					&buf);

This is not the correct way to indent a function call that spans
multiple lines.  In such a situation the arguments that appear
on the second and subsequent lines must start at the first column
after the openning parenthesis of the function call.

Like this:

	func(a, b, c,
	     d, e, f);

Please audit this in your entire set of patches and resubmit,
thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html