netdev - Re: [PATCHv2 net-next 1/7] epic100: replace printk with netdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 31 Oct 2013 21:36:12 -0700
From:	Joe Perches <joe@...ches.com>
To:	Ben Boeckel <mathstuf@...il.com>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCHv2 net-next 1/7] epic100: replace printk with netdev_
 calls

On Fri, 2013-11-01 at 00:27 -0400, Ben Boeckel wrote:
> Signed-off-by: Ben Boeckel <mathstuf@...il.com>

Nice (really, nicely done!) but:

> diff --git a/drivers/net/ethernet/smsc/epic100.c b/drivers/net/ethernet/smsc/epic100.c
[]
> @@ -1324,7 +1316,7 @@ static int epic_close(struct net_device *dev)
>  		ep->rx_ring[i].buflength = 0;
>  		if (skb) {
>  			pci_unmap_single(pdev, ep->rx_ring[i].bufaddr,
> -				 	 ep->rx_buf_sz, PCI_DMA_FROMDEVICE);
> +					 ep->rx_buf_sz, PCI_DMA_FROMDEVICE);

Please either mention the whitespace changes in the
changelog or don't do them in the same patch.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html