netdev - Re: [PATCH net-next 17/24] net: cdc_ncm: use netif_* and dev_* instead of pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 01 Nov 2013 03:36:54 -0700
From:	Joe Perches <joe@...ches.com>
To:	Bjørn Mork <bjorn@...k.no>
Cc:	netdev@...r.kernel.org, linux-usb@...r.kernel.org,
	Alexey Orishko <alexey.orishko@...il.com>
Subject: Re: [PATCH net-next 17/24] net: cdc_ncm: use netif_* and dev_*
 instead of pr_*

On Fri, 2013-11-01 at 11:16 +0100, Bjørn Mork wrote:
> Take advantage of standard device name prefixing and
> netdevice msglvl control where possible.

Nice, thanks.

You did most all the multi-line statement
alignment perfectly but missed a couple.

Maybe in a follow-on patch.

> diff --git a/drivers/net/usb/cdc_ncm.c b/drivers/net/usb/cdc_ncm.c
[]
> @@ -1031,17 +1035,13 @@ cdc_ncm_speed_change(struct usbnet *dev,
>  	 * device speed. Do print it instead.
>  	 */
>  	if ((tx_speed > 1000000) && (rx_speed > 1000000)) {
> -		printk(KERN_INFO KBUILD_MODNAME
> -		       ": %s: %u mbit/s downlink "
> -		       "%u mbit/s uplink\n",
> -		       dev->net->name,
> +		netif_info(dev, link, dev->net,
> +		       "%u mbit/s downlink %u mbit/s uplink\n",
>  		       (unsigned int)(rx_speed / 1000000U),
>  		       (unsigned int)(tx_speed / 1000000U));
>  	} else {
> -		printk(KERN_INFO KBUILD_MODNAME
> -		       ": %s: %u kbit/s downlink "
> -		       "%u kbit/s uplink\n",
> -		       dev->net->name,
> +		netif_info(dev, link, dev->net,
> +		       "%u kbit/s downlink %u kbit/s uplink\n",
>  		       (unsigned int)(rx_speed / 1000U),
>  		       (unsigned int)(tx_speed / 1000U));
>  	}


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html