lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 01 Nov 2013 03:52:48 -0700 From: Eric Dumazet <eric.dumazet@...il.com> To: Veaceslav Falico <vfalico@...hat.com> Cc: Dan Carpenter <dan.carpenter@...cle.com>, Jay Vosburgh <fubar@...ibm.com>, Andy Gospodarek <andy@...yhouse.net>, netdev@...r.kernel.org, kernel-janitors@...r.kernel.org, Jiri Pirko <jiri@...nulli.us> Subject: Re: [patch -next] bonding: bond_get_size() returns wrong size On Fri, 2013-11-01 at 11:41 +0100, Veaceslav Falico wrote: > On Fri, Nov 01, 2013 at 01:18:44PM +0300, Dan Carpenter wrote: > >There is an extra semi-colon so bond_get_size() doesn't return the > >correct value. > > > >Fixes: ec76aa49855f ('bonding: add Netlink support active_slave option') > >Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com> > > Hrm, how does it even build. Good catch, thanks. > > Acked-by: Veaceslav Falico <vfalico@...hat.com> Yep, an alternative is to use following format : static inline size_t br_port_info_size(void) { return nla_total_size(1) /* IFLA_BRPORT_STATE */ + nla_total_size(2) /* IFLA_BRPORT_PRIORITY */ + nla_total_size(4) /* IFLA_BRPORT_COST */ + nla_total_size(1) /* IFLA_BRPORT_MODE */ + nla_total_size(1) /* IFLA_BRPORT_GUARD */ + nla_total_size(1) /* IFLA_BRPORT_PROTECT */ + nla_total_size(1) /* IFLA_BRPORT_FAST_LEAVE */ + nla_total_size(1) /* IFLA_BRPORT_LEARNING */ + nla_total_size(1) /* IFLA_BRPORT_UNICAST_FLOOD */ + 0; } So that a patch adding a new attribute doesn't have to change the 'last line' -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists