netdev - Re: [PATCH net-next 08/11] openvswitch: Per cpu flow stats.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 2 Nov 2013 14:51:34 -0700
From:	Jesse Gross <jesse@...ira.com>
To:	David Miller <davem@...emloft.net>
Cc:	netdev <netdev@...r.kernel.org>,
	"dev@...nvswitch.org" <dev@...nvswitch.org>,
	Pravin Shelar <pshelar@...ira.com>
Subject: Re: [PATCH net-next 08/11] openvswitch: Per cpu flow stats.

On Tue, Oct 29, 2013 at 7:11 PM, David Miller <davem@...emloft.net> wrote:
> From: Jesse Gross <jesse@...ira.com>
> Date: Tue, 29 Oct 2013 17:22:21 -0700
>
>> From: Pravin B Shelar <pshelar@...ira.com>
>>
>> With mega flow implementation ovs flow can be shared between
>> multiple CPUs which makes stats updates highly contended
>> operation. Following patch allocates separate stats for each
>> CPU to make stats update scalable.
>>
>> Signed-off-by: Pravin B Shelar <pshelar@...ira.com>
>> Signed-off-by: Jesse Gross <jesse@...ira.com>
>
> Please properly use __percpu memory for this.
>
> Using arrays for this is very strongly discouraged, please instead
> use the kernel facility designed exactly for this.

Pravin had some concerns about the effects of high churn rate on the
percpu allocator, which is why he did it this way initially. I'm going
to drop this patch for now and send out the rest of the series while
he investigates further.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html