lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 4 Nov 2013 17:27:19 -0700 From: Jason Gunthorpe <jgunthorpe@...idianresearch.com> To: Sebastian Hesselbarth <sebastian.hesselbarth@...il.com> Cc: David Miller <davem@...emloft.net>, Lennert Buytenhek <buytenh@...tstofly.org>, Jason Cooper <jason@...edaemon.net>, Andrew Lunn <andrew@...n.ch>, Benjamin Herrenschmidt <benh@...nel.crashing.org>, netdev@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org Subject: [PATCH] net: mv643xx_eth: Add missing phy_addr_set in DT mode Commit cc9d4598 'net: mv643xx_eth: use of_phy_connect if phy_node present' made the call to phy_scan optional, if the DT has a link to the phy node. However phy_scan has the side effect of calling phy_addr_set, which writes the phy MDIO address to the ethernet controller. If phy_addr_set is not called, and the bootloader has not set the correct address then the driver will fail to function. Tested on Kirkwood. Signed-off-by: Jason Gunthorpe <jgunthorpe@...idianresearch.com> --- Cc: David Miller <davem@...emloft.net> Cc: Lennert Buytenhek <buytenh@...tstofly.org> Cc: Jason Cooper <jason@...edaemon.net> Cc: Andrew Lunn <andrew@...n.ch> Cc: Benjamin Herrenschmidt <benh@...nel.crashing.org> Cc: netdev@...r.kernel.org Cc: linux-arm-kernel@...ts.infradead.org Cc: linuxppc-dev@...ts.ozlabs.org Cc: linux-kernel@...r.kernel.org --- drivers/net/ethernet/marvell/mv643xx_eth.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/marvell/mv643xx_eth.c b/drivers/net/ethernet/marvell/mv643xx_eth.c index 2c210ec..00e43b5 100644 --- a/drivers/net/ethernet/marvell/mv643xx_eth.c +++ b/drivers/net/ethernet/marvell/mv643xx_eth.c @@ -2890,6 +2890,7 @@ static int mv643xx_eth_probe(struct platform_device *pdev) PHY_INTERFACE_MODE_GMII); if (!mp->phy) err = -ENODEV; + phy_addr_set(mp, mp->phy->addr); } else if (pd->phy_addr != MV643XX_ETH_PHY_NONE) { mp->phy = phy_scan(mp, pd->phy_addr); -- 1.8.1.2 -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists