netdev - Re: [PATCH v2 2/2] ixgbe: enable l2 forwarding acceleration for macvlans

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 04 Nov 2013 22:24:46 -0800
From:	John Fastabend <john.r.fastabend@...el.com>
To:	nhorman@...driver.com, alexander.h.duyck@...el.com
CC:	netdev@...r.kernel.org, andy@...yhouse.net, davem@...emloft.net,
	jeffrey.t.kirsher@...el.com
Subject: Re: [PATCH v2 2/2] ixgbe: enable l2 forwarding acceleration for macvlans

On 11/4/2013 11:01 AM, John Fastabend wrote:
> Now that l2 acceleration ops are in place from the prior patch,
> enable ixgbe to take advantage of these operations.  Allow it to
> allocate queues for a macvlan so that when we transmit a frame,
> we can do the switching in hardware inside the ixgbe card, rather
> than in software.
>
> For now this patch limits the hardware to 8 offloaded macvlan ports.
> A follow on patch will remove this limitation but to simplify
> review/validation of the new macvlan offload ops we leave it at 8
> for now.
>
> Signed-off-by: John Fastabend <john.r.fastabend@...el.com>
> CC: Andy Gospodarek <andy@...yhouse.net>
> CC: "David S. Miller" <davem@...emloft.net>
> ---

[...]

>
>   #define IXGBE_MAX_RSS_INDICES  16
> -#define IXGBE_MAX_VMDQ_INDICES 64
> +#define IXGBE_MAX_VMDQ_INDICES	8

This define is also used for max VFs in SR-IOV mode so we can't just
redefine it like this without also limiting SR-IOV.

[...]

> +static void ixgbe_fwd_del(struct net_device *pdev, void *priv)
> +{
> +	struct ixgbe_fwd_adapter *fwd_adapter = priv;
> +	struct ixgbe_adapter *adapter = fwd_adapter->real_adapter;
> +
> +	clear_bit(fwd_adapter->pool, &adapter->fwd_bitmask);
> +	adapter->num_rx_pools--;
> +
> +	ixgbe_fwd_ring_down(fwd_adapter->netdev, fwd_adapter);
> +
> +	netdev_dbg(pdev, "pool %i:%i queues %i:%i VSI bitmask %lx\n",
> +		   fwd_adapter->pool, adapter->num_rx_pools,
> +		   fwd_adapter->rx_base_queue,
> +		   fwd_adapter->rx_base_queue + adapter->num_rx_queues_per_pool,
> +		   adapter->fwd_bitmask);

Missing a kfree(fwd_adapter) here, and a ixgbe_setup_tc() call to
release the queues.

I'm testing a fix now and will send a v3.

Thanks,
John
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html