netdev - Re: [PATCH net-next] 8390 : Replace ei_debug with msg_enable/NETIF_MSG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 06 Nov 2013 15:49:13 -0800
From:	Joe Perches <joe@...ches.com>
To:	Matthew Whitehead <tedheadster@...il.com>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next] 8390 : Replace ei_debug with
 msg_enable/NETIF_MSG_* feature

On Wed, 2013-11-06 at 15:56 -0500, Matthew Whitehead wrote:
> Removed the shared ei_debug variable. Replaced it by adding u32 msg_enable to
> the private struct ei_device. Now each 8390 ethernet instance has a per-device
> logging variable.
> 
> Changed printk() calls to netdev_(dbg|info|warn|err) when possible.

Hello Matthew.

Ideally, some of these would use:

	netif_<level>(struct ei_device *, type, struct net_device *, fmt, ...)

> @@ -352,10 +360,12 @@ static void
[]
> +    if (ei_local->msg_enable & NETIF_MSG_HW)
> +		netdev_dbg(dev, "resetting the 8390 t=%ld...\n", jiffies);

	netif_dbg(ei_local, hw, dev, "resetting the 8390 t=%...\n", jiffies);

> +++ b/drivers/net/ethernet/8390/ax88796.c
> @@ -147,8 +149,8 @@ static void ax_reset_8390(struct net_device *dev)
>  	unsigned long reset_start_time = jiffies;
>  	void __iomem *addr = (void __iomem *)dev->base_addr;
>  
> -	if (ei_debug > 1)
> -		netdev_dbg(dev, "resetting the 8390 t=%ld\n", jiffies);
> +	if (ei_local->msg_enable & NETIF_MSG_HW)
> +		netdev_dbg(dev, "resetting the 8390 t=%ld...\n", jiffies);

	netif_dbg(ei_local, hw, dev, "resetting" etc...);


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html