lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 05 Nov 2013 20:23:05 -0800 From: Eric Dumazet <eric.dumazet@...il.com> To: Herbert Xu <herbert@...dor.apana.org.au> Cc: Ben Hutchings <bhutchings@...arflare.com>, David Miller <davem@...emloft.net>, christoph.paasch@...ouvain.be, netdev@...r.kernel.org, hkchu@...gle.com, mwdalton@...gle.com Subject: Re: gso: Attempt to handle mega-GRO packets On Wed, 2013-11-06 at 12:07 +0800, Herbert Xu wrote: > On Tue, Nov 05, 2013 at 05:45:47PM -0800, Eric Dumazet wrote: > > > > Hmm, I do not think fskb has the headers in the general case. > > Only GRO produces such packets, see the changeset where I added > frag_list support to skb_setgment Nope, I already mentioned this : Please take a look at 2613af0ed18a11d5c566a81f9a6510b73180660a ("virtio_net: migrate mergeable rx buffers to page frag allocators") I do not see why skb_segment() would be tied to GRO -> GSO, with the property of each page frag being exactly MSS sized. We use it in TCP stack with page frags of any size. skb_segment() needs to iterate properly on all pages frags, the one found in the first skb, and the ones found on frag_list skbs. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists