lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 07 Nov 2013 18:42:34 -0800 From: Eric Dumazet <eric.dumazet@...il.com> To: Herbert Xu <herbert@...dor.apana.org.au> Cc: David Miller <davem@...emloft.net>, bhutchings@...arflare.com, christoph.paasch@...ouvain.be, netdev@...r.kernel.org, hkchu@...gle.com, mwdalton@...gle.com Subject: Re: [PATCH v4 net-next] net: introduce dev_set_forwarding() On Fri, 2013-11-08 at 10:17 +0800, Herbert Xu wrote: > Oh no let's keep it as it is indeed a great cleanup and improvement > for LRO. We can however remove the bits that relate to GRO. What about doing a benchmark first ? I benchmarked the 'locally delivered' traffic, not the forwarding one. That's why I am not comfortable of having large GRO packets that need to be segmented. You tell us hardware advantage of TSO is negligible, this is not what I observe today on many platforms. A normal TSO packets with 16 MSS setups a ~17 DMA descriptors, while GSO requires 2 DMA descriptors per MSS, plus a lot of overhead in sk_buff allocation/deallocation. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists