| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Fri, 8 Nov 2013 12:10:16 +0800 From: Herbert Xu <herbert@...dor.apana.org.au> To: Eric Dumazet <eric.dumazet@...il.com> Cc: David Miller <davem@...emloft.net>, bhutchings@...arflare.com, christoph.paasch@...ouvain.be, netdev@...r.kernel.org, hkchu@...gle.com, mwdalton@...gle.com Subject: Re: [PATCH v4 net-next] net: introduce dev_set_forwarding() On Thu, Nov 07, 2013 at 08:06:34PM -0800, Eric Dumazet wrote: > On Fri, 2013-11-08 at 11:22 +0800, Herbert Xu wrote: > > > If it really hurt then they can always turn it off using ethtool. > > With your patch that automatically turns it off virt folks have > > no way of even turning it on. > > Let me remind you that before the GRO frag_list patch, virt folks had no > choice anyway. GRO packets were limited to 16 MSS. > > Its not because we can build large packets that we must do so. > > This was an error of our TSO implementation. Well you still don't seem to be getting this: If you need it for the host then you will need it even more for virt because the network stack there is much longer. So having it only available to the host without also giving it to virt makes *zero* sense. Cheers, -- Email: Herbert Xu <herbert@...dor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists