netdev - Re: [PATCH net v2] ipv4: fix wildcard search with inet_confirm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 14 Nov 2013 11:32:53 +0100
From:	Nicolas Dichtel <nicolas.dichtel@...nd.com>
To:	Julian Anastasov <ja@....bg>
CC:	davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [PATCH net v2] ipv4: fix wildcard search with inet_confirm_addr()

Le 13/11/2013 22:27, Julian Anastasov a écrit :
>
> 	Hello,
>
> On Wed, 13 Nov 2013, Nicolas Dichtel wrote:
>
>> Help of this function says: "in_dev: only on this interface, 0=any interface",
>> but since commit 39a6d0630012 ("[NETNS]: Process inet_confirm_addr in the
>> correct namespace."), the code supposes that it will never be NULL. This
>> function is never called with in_dev == NULL, but it's exported and may be used
>> by an external module.
>>
>> Because this patch restore the ability to call inet_confirm_addr() with in_dev
>> == NULL, I partially revert the above commit, as suggested by Julian.
>>
>> CC: Julian Anastasov <ja@....bg>
>> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@...nd.com>
>
> 	This patch looks ok to me, thanks!
>
> Reviewed-by: Julian Anastasov <ja@....bg>
>
> 	Still, I think this is a net-next material
> and you have to wait some days... The net tree that
Ok.

> you are using is missing the changes that remove
> 'extern', so I think you have to port it to net-next
> tree to avoid the conflict in include/linux/inetdevice.h.
Yes, checkpatch already warns about this extern kerword.

Thank you,
Nicolas
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html