netdev - Re: [RFC 3/8] quota/genetlink: use proper genetlink multicast APIs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 18 Nov 2013 13:44:54 +0100
From:	Johannes Berg <johannes@...solutions.net>
To:	Jan Kara <jack@...e.cz>
Cc:	netdev@...r.kernel.org
Subject: Re: [RFC 3/8] quota/genetlink: use proper genetlink multicast APIs

On Mon, 2013-11-18 at 13:34 +0100, Jan Kara wrote:

> Ah, sorry for messing that up. When I was writing this, libnl didn't have
> support for multicast groups and so I didn't figure out from its documentation
> there are any multicast groups at all... I'd also mention that
> documentation of generic netlink at
> http://www.linuxfoundation.org/collaborate/workgroups/networking/generic_netlink_howto
> (pointed to from Documenation/networking/generic_netlink.txt) doesn't
> mention anything about multicast groups either. So chances for messing
> things up are pretty high...

Bugger. I guess we should take a look at adding something about
multicast groups etc.

> Anyway, I'll fix quota_nld (userspace daemon consuming quota netlink
> messages) to use multicast groups properly with a fallback to previous
> behavior in case that fails (to keep compatibility with older kernels) and
> since I don't believe anyone else is using this interface (and even
> quota_nld isn't widely used), 

Heh. If you want a different group name, that's fine, I just gave it any
name ... We could call it "events" for example, since the group name is
always qualified by the family name anyway.

I'll remove the comment about it not being really used as well then.

> I think we can remove this hack from generic
> netlink layer in a couple of years (hurray to a paragraph long
sentence
> ;).

:)

> Thanks for fixing this and you can add:
> Acked-by: Jan Kara <jack@...e.cz>

Will do, thanks.

johannes

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html