lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 28 Nov 2013 02:11:33 +0000 From: Ben Hutchings <bhutchings@...arflare.com> To: Guenter Roeck <linux@...ck-us.net> CC: <netdev@...r.kernel.org>, <linux-net-drivers@...arflare.com>, <lm-sensors@...sensors.org> Subject: Re: [PATCH] sfc: Convert to use hwmon_device_register_with_groups On Tue, 2013-11-26 at 19:33 -0800, Guenter Roeck wrote: > Simplify the code. Avoid race conditions caused by attributes > being created after hwmon device registration. Implicitly > (through hwmon API) add mandatory 'name' sysfs attribute. > > Signed-off-by: Guenter Roeck <linux@...ck-us.net> > --- > Compile tested only. [...] Very close, but you missed this bit: --- a/drivers/net/ethernet/sfc/mcdi_mon.c +++ b/drivers/net/ethernet/sfc/mcdi_mon.c @@ -142,7 +142,7 @@ static int efx_mcdi_mon_update(struct efx_nic *efx) static int efx_mcdi_mon_get_entry(struct device *dev, unsigned int index, efx_dword_t *entry) { - struct efx_nic *efx = dev_get_drvdata(dev); + struct efx_nic *efx = dev_get_drvdata(dev->parent); struct efx_mcdi_mon *hwmon = efx_mcdi_mon(efx); int rc; --- With that addition, it works for me, and you can add my Reviewed-by. Ben. -- Ben Hutchings, Staff Engineer, Solarflare Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists